Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job.fastUpdateNextBuildNumber #9019

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Mar 7, 2024

Introduces a minimal beta API that has been used successfully in CloudBees CI to reload a Job.nextBuildNumber from disk. The existing updateNextBuildNumber is not well suited to this purpose because it forces loading of the last build and also saves the value back to disk, noticeably increasing disk I/O when called frequently on a slower filesystem.

Testing done

Integration tests exist in CloudBees CI.

Proposed changelog entries

  • N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

@jglick jglick requested review from Vlatombe and julieheard March 7, 2024 20:28
@NotMyFault NotMyFault requested a review from a team March 9, 2024 14:33
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 9, 2024
@MarkEWaite MarkEWaite added the skip-changelog Should not be shown in the changelog label Mar 9, 2024
@NotMyFault NotMyFault merged commit 2dca2b1 into jenkinsci:master Mar 10, 2024
16 checks passed
@jglick jglick deleted the fastUpdateNextBuildNumber branch March 11, 2024 17:53
@jglick jglick mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants